Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

feat: plumb peerstore contexts changes through #75

Merged
merged 1 commit into from
Nov 10, 2021
Merged

feat: plumb peerstore contexts changes through #75

merged 1 commit into from
Nov 10, 2021

Conversation

guseggert
Copy link
Contributor

No description provided.

@guseggert guseggert mentioned this pull request Nov 10, 2021
Closed
marten-seemann
marten-seemann approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the hosts type is removed (see comment).

backoffconnector_test.go Outdated Show resolved Hide resolved
marten-seemann
marten-seemann approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (staticcheck is failing though, still needs to be fixed)

@guseggert guseggert merged commit f0965e4 into master Nov 10, 2021
@guseggert guseggert deleted the feat/context branch November 10, 2021 20:50
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
Closed
80 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guseggert @marten-seemann