New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create a token on every call in the portworx driver #325

Open

lpabon opened this issue Apr 1, 2019 · 0 comments

Member

lpabon commented Apr 1, 2019

Is this a BUG REPORT or FEATURE REQUEST?:
Bug

What happened:
Generating a token is expensive if done very often, they involve crypto calls. Please file a bug to track that.
Example of how kubernetes deals with OIDC tokens to alleviate this: https://github.com/kubernetes/client-go/blob/master/plugin/pkg/client/auth/oidc/oidc.go#L332

See: #324 (comment)

What you expected to happen:
The driver should only create it when needed.

lpabon mentioned this issue

Authorization support for Portworx #324

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment