Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use autogenerated ABI target list #83

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

malept
Copy link
Member

@malept malept commented Mar 19, 2020

Uses the following sources to autogenerate a relatively recent ABI registry on a daily basis and commit the changes to master:

This should avoid the issues generated whenever a new major Node/Electron version is released.

The GitHub Action is based on something similar I created for Electron Fiddle.

@malept
Copy link
Member Author

malept commented Mar 28, 2020

CC: @MarshallOfSound

@mafintosh
Copy link
Contributor

This looks like a good idea. I don't know how to update the publishing etc. Maybe @lgeiger knows? Could also be combined with resolving #58

malept added 2 commits August 11, 2020 09:46
`yarn update-abi-registry` generates `abi_registry.json`, which is
loaded by the module to determine relatively recent ABI targets, along
with their LTS values and whether they are "future" targets.
@MarshallOfSound MarshallOfSound merged commit 3f6f27a into electron:master Aug 20, 2020
@lgeiger
Copy link
Contributor

lgeiger commented Aug 20, 2020

🎉 This PR is included in version 2.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants