feat(preview): attach to popup if already open #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should add an option |
lewis6991
reviewed
Sep 13, 2022
lewis6991
reviewed
Sep 13, 2022
seblyng
force-pushed
the
attach_to_popup
branch
2 times, most recently
from
b06b654 to
d8b9bbb
Compare
|
I don't really like the name |
lewis6991
reviewed
Sep 13, 2022
lewis6991
reviewed
Sep 13, 2022
lewis6991
reviewed
Sep 13, 2022
lewis6991
reviewed
Sep 13, 2022
teal/gitsigns/popup.tl
Outdated
Comment on lines
194
to
195
| local exists = pcall(api.nvim_win_get_var, winid, var) | ||
| if exists then |
There was a problem hiding this comment.
Suggested change
| local exists = pcall(api.nvim_win_get_var, winid, var) | |
| if exists then | |
| if vim.w[winid][var] ~= nil then |
There was a problem hiding this comment.
Doing this requires to change types.d.tl so we don't get a compile error. However I couldn't get it to work. Any tips on how to do it?
lewis6991
reviewed
Sep 13, 2022
seblyng
force-pushed
the
attach_to_popup
branch
from
d8b9bbb to
5e423c3
Compare
lewis6991
force-pushed
the
attach_to_popup
branch
from
5e423c3 to
10be4fe
Compare
|
I've gone ahead and fixed up the PR |
Thanks! That looks better |
lewis6991
changed the title
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree with your comment here: #609 (comment)
Made it to always attach to the popup if it's already open