Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Custom ESP32-C3 build: cannot set name in Custom.h #4936

Closed
chemmex opened this issue Jan 12, 2024 · 5 comments
Closed

[BUG] Custom ESP32-C3 build: cannot set name in Custom.h #4936

chemmex opened this issue Jan 12, 2024 · 5 comments

Comments

@chemmex
Copy link

chemmex commented Jan 12, 2024

Despite DEFAULT_NAME is defined in Config.h, system name falls back to ESPEasy
@TD-er
Copy link
Member

TD-er commented Jan 12, 2024

Yep, that's being fixed too :)
See: #4932

@chemmex
Copy link
Author

chemmex commented Jan 12, 2024

Great, waiting for it to be merged

@TD-er
Copy link
Member

TD-er commented Jan 12, 2024

Just tested it a bit more and it still isn't fixed, so you don't need to try the PR branch to test for yourself :(

@iz8mbw
Copy link
Contributor

iz8mbw commented Jan 18, 2024

Can this be closed thanks to #4932 ?

@chemmex
Copy link
Author

chemmex commented Jan 18, 2024

Yes, definitely

@chemmex chemmex closed this as completed Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iz8mbw @TD-er @chemmex