Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Fluent Navigation projects have several issues #361

Closed
hoagsie opened this issue Aug 27, 2022 · 2 comments
Closed

New Fluent Navigation projects have several issues #361

hoagsie opened this issue Aug 27, 2022 · 2 comments
Assignees
Labels
bug Something isn't working locked-due-to-inactivity MVVM_DI Issues related to MVVM and Dependency Injection.

Comments

@hoagsie
Copy link

hoagsie commented Aug 27, 2022

Describe the bug
New projects will not build with (as of writing) the latest VS 2022 (17.3.1)/dotnet 6.0.400 build. This seems to be largely due to a regression in dotnet 6.

dotnet/wpf#6792

There is a workaround outlined here.

dotnet/wpf#6792 (comment)

I see you're already aware of this issue though.

#289

There is one more issue. Microsoft.Toolkit.Mvvm is deprecated in favor of CommunityToolkit.Mvvm. Switching out the packages has some reference issues that are easy to clean up. However, ICommand is no longer available. Doing a nuget search to see where else this could live, I can only find references to the Microsoft.Toolkit.Mvvm package. This will require either a backfill or looking for an alternate solution. I just started using wpfui today so I'm not terribly confident in issuing a PR with either approach. Interestingly, if you install both packages and repoint everything except for ICommand to the new community toolkit the app seems to work fine, but that's an ugly bandaid.

To Reproduce
Steps to reproduce the behavior:
0. Make sure VS version 17.3.1 and dotnet 6.0.400 are installed.

  1. Install the WPFUI extension into the VS 2022 installation.
  2. Use the Create a new project flow to create a WPF UI - Fluent Navigation project.
  3. Try to build.
  4. Observe errors.

Expected behavior
New projects should build/run out of the box.

Desktop (please complete the following information):

  • OS: Version 10.0.22000 Build 22000 (Windows 11)
  • .NET:
dotnet --list-sdks
3.1.422 [C:\Program Files\dotnet\sdk]
5.0.400 [C:\Program Files\dotnet\sdk]
5.0.408 [C:\Program Files\dotnet\sdk]
6.0.203 [C:\Program Files\dotnet\sdk]
6.0.303 [C:\Program Files\dotnet\sdk]
6.0.400 [C:\Program Files\dotnet\sdk]
  • Version: WPF-UI 2.0.2

Additional context

VS info dump
Microsoft Visual Studio Community 2022
Version 17.3.1
VisualStudio.17.Release/17.3.1+32811.315
Microsoft .NET Framework
Version 4.8.04161

Installed Version: Community

Visual C++ 2022   00482-90000-00000-AA942
Microsoft Visual C++ 2022

ASP.NET and Web Tools   17.3.375.53775
ASP.NET and Web Tools

Azure App Service Tools v3.0.0   17.3.375.53775
Azure App Service Tools v3.0.0

Azure Functions and Web Jobs Tools   17.3.375.53775
Azure Functions and Web Jobs Tools

C# Tools   4.3.0-3.22401.3+41ae77386c335929113f61d6f51f2663d2780443
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

CodeMaid   12.0
CodeMaid is an open source Visual Studio extension to cleanup and simplify our C#, C++, F#, VB, PHP, PowerShell, R, JSON, XAML, XML, ASP, HTML, CSS, LESS, SCSS, JavaScript and TypeScript coding.

Common Azure Tools   1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

Cookiecutter   17.0.22179.3
Provides tools for finding, instantiating and customizing templates in cookiecutter format.

Extensibility Message Bus   1.2.6 (master@34d6af2)
Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration.

Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

Mono Debugging for Visual Studio   17.3.20 (3f4cb00)
Support for debugging Mono processes with Visual Studio.

Node.js Tools   1.5.40629.1 Commit Hash:3f5cc0329815af3ffb948f08857446d206a9af36
Adds support for developing and debugging Node.js apps in Visual Studio

NuGet Package Manager   6.3.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/

Python - Profiling support   17.0.22179.3
Profiling support for Python projects.

Python - VC Project Support   17.0.21344.1
Provides support for launching C++ projects with Python debugging enabled.

Python with Pylance   17.0.22179.3
Provides IntelliSense, projects, templates, debugging, interactive windows, and other support for Python developers.

Razor (ASP.NET Core)   17.0.0.2232702+e1d654e792aa2fe6646a6935bcca80ff0aff4387
Provides languages services for ASP.NET Core Razor.

SQL Server Data Tools   17.0.62207.04100
Microsoft SQL Server Data Tools

SVG Viewer   1.0.15
Makes it much easier to work with SVG files by showing a live preview in the bottom-right corner of the code window

Syntax Visualizer   1.0
An extension for visualizing Roslyn SyntaxTrees.

TypeScript Tools   17.0.10701.2001
TypeScript Tools for Microsoft Visual Studio

Visual Basic Tools   4.3.0-3.22401.3+41ae77386c335929113f61d6f51f2663d2780443
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual F# Tools   17.1.0-beta.22363.4+1b94f89d4d1f41f20f9be73c76f4b229d4e49078
Microsoft Visual F# Tools

Visual Studio IntelliCode   2.2
AI-assisted development for Visual Studio.

VisualStudio.DeviceLog   1.0
Information about my package

VisualStudio.Mac   1.0
Mac Extension for Visual Studio

VSPackage Extension   1.0
VSPackage Visual Studio Extension Detailed Info

Xamarin   17.3.0.296 (d17-3@a0ff24b)
Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.

Xamarin Designer   17.3.0.208 (remotes/origin/d17-3@e4f67afef)
Visual Studio extension to enable Xamarin Designer tools in Visual Studio.

Xamarin Templates   17.2.28 (9b3d244)
Templates for building iOS, Android, and Windows apps with Xamarin and Xamarin.Forms.

Xamarin.Android SDK   13.0.0.0 (d17-3/030cd63)
Xamarin.Android Reference Assemblies and MSBuild support.
    Mono: dffa5ab
    Java.Interop: xamarin/java.interop/d17-3@7716ae53
    SQLite: xamarin/sqlite/3.38.5@df4deab
    Xamarin.Android Tools: xamarin/xamarin-android-tools/main@14076a6


Xamarin.iOS and Xamarin.Mac SDK   15.12.0.2 (87f98a75e)
Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support.
@hoagsie hoagsie added the bug Something isn't working label Aug 27, 2022
@pomianowski
Copy link
Member

pomianowski commented Aug 27, 2022

Hey, thank you for paying attention to the Microsoft Toolkit depractation. The demo application has already been moved to the Community Toolkit in this commit. The plugin templates were also updated in the same commit.

@pomianowski pomianowski added the MVVM_DI Issues related to MVVM and Dependency Injection. label Aug 27, 2022
@hoagsie
Copy link
Author

hoagsie commented Aug 27, 2022

Nice. I look forward to the next release!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working locked-due-to-inactivity MVVM_DI Issues related to MVVM and Dependency Injection.
Projects
None yet
Development

No branches or pull requests

2 participants