-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Discord Dynamic Paths detection, Flatpak and NixOS #65
base: master
Are you sure you want to change the base?
Conversation
Fix the error that causes multiple people to get the Could not find Discord executable. When installing with Flatpak, and different distros due to the process name not being Exactly 'Discord-Helper'
Dynamically fetch config directory path as such fixes issues from snap and flatpak users as well as addressing issues such as #66. |
Also fixes #53 |
This comment has been minimized.
This comment has been minimized.
@tadeokondrak should be fixed now. Let me know if theres anything else. |
Config path autofinding still not in the main branch. The injection patch changed to use .cache |
I've attempted to use this branch on NixOS version 20.03 and while it succeeded to find discord, it hangs before reporting the following:
Notable is that there are files under that directory which appear to be acting as normal (although the package.json does list the "version" property as "0.0.0", however changing this to "0.0.10" fixes nothing) |
Hey @IGJoshua can you post a |
package.json {"name":"discord_desktop_core","version":"0.0.0","private":"true","main":"index.js"} |
@IGJoshua Hey, mind trying it now ?. It should be fixed |
@SparrowOchon Awesome, it works! Thanks! |
Trying to use this with a flatpak installation, and it never writes core.asar. Just moves the old one to original_core.asar and causes Discord to fail to start. |
Truth be told, I don't use Discord, and seeing as this most likely won't ever be merged I won't bother putting time into keeping this up to date. Feel free to make modifications or fork my fork. @unresolvedsymbol This is most likely related to the directory not being found thus, with the discord update. Make sure the in the @GunnerBasil There should be nothing stopping this from working on Arch already. Auto path detection is distro independent. |
Some people have been having trouble finding discord and being given; " Could not find Discord executable" this is mainly due to the change in discord name in different installation. As such it is related to;
fixes #62
fixes #25
and supersedes; Pull Request #63