-
Notifications
You must be signed in to change notification settings - Fork 30
Reduce lib size #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey @icebob,
|
I found leven. It's only 2.3kB, but it's a Levenshtein distance algorithm. |
Okay, do you want to create a PR? |
Yes, I will. |
Thanks! Maybe we should wait until #116 is merged?! |
When will it be merged? |
Done 👍 |
Great! I'm trying to change similarity lib... |
I'm trying, but how can I test it? I see there is no test case for similarity and I don't know when this code is called. Could you help me? |
You can create a file, where you require your local
#!/usr/bin/env node
const args = require('../args/lib/')
args
.option('t', 'This is a test', 'foo')
.option('verbose', 'verbose option', 'jep')
const flags = args.parse(process.argv, {
version: false,
mri: {
string: 't'
}
})
console.log(flags) switch to that dir and run |
I'm done. Could you check it? #121 |
@ntwcklng When can you check & merge it? |
I will look at it next week 👍 |
Released in 4.0.0, thanks @icebob 😎 |
Great! Me too! 😎 |
Hi,
I checked your lib size because it is~300kB: https://arve0.github.io/npm-download-size/#args
But your code is very small (1kB), but you have "string-similarity" dependency which is 300kB. 86% of the whole size.
Do you plan to change it to other smaller lib?
Thanks!
The text was updated successfully, but these errors were encountered: