Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[leo_object_storage] MD5 check doesn't happen in case GET with Range header with "is_strict_check = true" #947

Closed
mocchira opened this issue Dec 5, 2017 · 0 comments
Closed

[leo_object_storage] MD5 check doesn't happen in case GET with Range header with "is_strict_check = true" #947

mocchira opened this issue Dec 5, 2017 · 0 comments
Assignees
@mocchira
Labels
Bug _leo_object_storage Priority-MIDDLE S3-API
Milestone
1.4.2

Comments

@mocchira
Copy link
Member

mocchira commented Dec 5, 2017

MD5 check always should happen when is_strict_check = true regardless of whether Range header exists or not.
Where to fix: https://github.com/leo-project/leo_object_storage/blob/develop/src/leo_object_storage_haystack.erl#L567-L577
@mocchira mocchira added this to the 1.4.1 milestone Dec 5, 2017
@mocchira mocchira mentioned this issue Dec 5, 2017
Closed
@yosukehara yosukehara changed the title [leo_object_storage] MD5 check doesn't happen in case GET with Range header with is_strict_check = true [leo_object_storage] MD5 check doesn't happen in case GET with Range header with "is_strict_check = true" Feb 19, 2018
@mocchira mocchira modified the milestones: 1.4.1, 1.4.2 Apr 20, 2018
@mocchira mocchira mentioned this issue May 1, 2018
Merged
@mocchira mocchira self-assigned this May 2, 2018
@mocchira mocchira closed this as completed May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mocchira mocchira

Labels
Bug _leo_object_storage Priority-MIDDLE S3-API
Projects
None yet
Milestone
1.4.2
Development

No branches or pull requests
1 participant
@mocchira