Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include timestamp in FollowNotification #154

Open
iPaulPro opened this issue Dec 2, 2023 · 1 comment
Open

Include timestamp in FollowNotification #154

iPaulPro opened this issue Dec 2, 2023 · 1 comment

Comments

@iPaulPro
Copy link

iPaulPro commented Dec 2, 2023

Problem

FollowNotification returns an array of profiles that followed, but no timestamps for the follow events. The other batched notifications, ReactionNotification and ActedNotification, both include timestamps for the respective events.

Right now it's not possible to do something like query for the number of followers gained in the past 24 hours.

export type OpenActionProfileActedFragment = {
    actedAt: string;
    by: ProfileFragment;
    action: OpenActionResult_KnownCollectOpenActionResult_Fragment | OpenActionResult_UnknownOpenActionResult_Fragment;
};
export type ActedNotificationFragment = {
    __typename: 'ActedNotification';
    id: string;
    actions: Array<OpenActionProfileActedFragment>;
    publication: CommentFragment | MirrorFragment | PostFragment | QuoteFragment;
};
export type FollowNotificationFragment = {
    __typename: 'FollowNotification';
    id: string;
    followers: Array<ProfileFragment>;
};

Proposed solution

Follow the pattern of other batched notifications and include the timestamp of follows.

export type FollowNotificationFragment = {
    __typename: 'FollowNotification';
    id: string;
    follows: Array<{
        follower: ProfileFragment;
        followedAt: string;
    }>
};
@iPaulPro
Copy link
Author

Can we at least expect this in Lens V3? Any response would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant