Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
Iterable<E>.flatten(): Iterable<dynamic>
in favor ofIterable<Itearble<E>>.flatten(): Iterable<E>
andList<List<E>>.flatten(): List<E>
The old implementation wasn't type safe and risks a class cast exception
I consider this change as almost-non-breaking 😁
If
flatten()
was called on a non-nestedIterable<E>
whereE
is not aIterable
it would fail at runtime. So the code was already broken.The only exception is when
Iterable<dynamic>
is empty. For this code the method will not be available anymore.This PR is a alternative to #55