Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isUpperCase and isLowerCase #142

Merged
merged 3 commits into from
Oct 15, 2021

Conversation

minhqdao
Copy link
Contributor

@minhqdao minhqdao commented Oct 14, 2021

The behavior of isUpperCase so far is:

'1234'.isUpperCase // true
' '.isUpperCase // true
'!'.isUpperCase // true
'\n'.isUpperCase // true
'TEST'.isUpperCase // true
'TESt'.isUpperCase // false
'HEY, YOU!'.isUpperCase // true

This is being changed to:

'1234'.isUpperCase // false
' '.isUpperCase // false
'!'.isUpperCase // false
'\n'.isUpperCase // false
'TEST'.isUpperCase // true
'TESt'.isUpperCase // false
'HEY, YOU!'.isUpperCase // true

isLowerCase is also changed, respectively.

Will update readme in #141.

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #142 (21955ed) into master (6af8524) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   96.72%   96.73%           
=======================================
  Files          11       11           
  Lines         763      765    +2     
=======================================
+ Hits          738      740    +2     
  Misses         25       25           
Impacted Files Coverage Δ
lib/src/string.dart 86.44% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6af8524...21955ed. Read the comment docs.

@minhqdao
Copy link
Contributor Author

@passsy

@passsy
Copy link
Collaborator

passsy commented Oct 15, 2021

Definitly better than before 👍

@passsy passsy merged commit 5d863a2 into simc:master Oct 15, 2021
@minhqdao minhqdao deleted the fix-isUpperCase-isLowerCase branch October 15, 2021 13:25
@minhqdao minhqdao mentioned this pull request Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants