don't filter text, make special chars searchable #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel17903
approved these changes
Aug 21, 2022
…ltung into keep_all_values_in_search
|
@daniel17903 I don't understand why the tests fail :-/ |
|
Any updates on this? 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By disabling
cleanUserTextinAutoCompleteit would be possible to search for anything containing special characters, e.g.D'Angelo.Fixes #468
I think this should be rather safe. The data is already in the database. We do not perform any sanitation while creating the users or items. So insertion via
AutoCompletecannot do any more harm than this anyway.