Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the current status of the connector? #5

Closed
gregkare opened this issue Feb 26, 2016 · 5 comments
Closed

What is the current status of the connector? #5

gregkare opened this issue Feb 26, 2016 · 5 comments

Comments

@gregkare
Copy link

Hi, thanks for working on this.

Does "Redis Cluster support." under TODO in the README mean that it cannot be used to do queries yet? There's no example in the README.

Thanks in advance

@pintsized
Copy link
Member

Hi,

The connector is used in production in several places, so current status is that you can definitely rely upon it, and its ongoing maintenance. I left a space for eventually having Redis Cluster support, but for this to work we need a Redis client which supports cluster (or potentially a separate module which composes the Redis client in some way). See here: openresty/lua-resty-redis#43

@gregkare
Copy link
Author

I think I'm missing something. Does that mean that connecting to sentinel (as in the README) currently is not supported because the lua-resty-redis library doesn't have cluster support?

@pintsized
Copy link
Member

No, it means you need to understand the difference between Sentinel and Cluster better :)

http://redis.io/topics/sentinel
http://redis.io/topics/cluster-tutorial

Sentinel works just fine, and is proven in production. Cluster is a newer thing for Redis (although uses and is related to Sentinel), and requires quite a bit of effort on the part of the client, so all Redis clients will have to implement that logic in some way. The lua-resty-redis client has not yet gained this functionality officially, although some people have had a crack at it I believe.

When lua-resty-redis (or another module) can utilise Redis Cluster, then I'll add support for it to the lua-resty-redis-connector, who's job is merely to make connection logic reliable and repeatable.

@gregkare
Copy link
Author

Thanks, for the clarification! I was under the impression that "cluster" and "sentinel" were the same thing

@gregkare
Copy link
Author

I forgot to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants