Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Increase fee" does not replace the existing transaction but create a new transaction #4759

Closed
fyang1024 opened this issue Dec 29, 2023 · 2 comments

Comments

@fyang1024
Copy link

I am not sure if it's the wallet's issue or the stacks blockchain's issue.
When I increase fee for an pending transaction, it does not replace the existing transaction but create a new transaction

https://explorer.hiro.so/txid/0x297dc1eb1417afad7c95836c2f1136f8afcf38e83d677a9d9531f3d21384d215?chain=testnet is the original transaction
https://explorer.hiro.so/txid/0xdf2ff5d9d58fe5bf05ff0a559abbd35f56fda1d0d528181bbfa87e51c2d64323?chain=testnet is the transaction when I increased the fee

@314159265359879
Copy link
Contributor

Thanks for posting. I saw you also posted on the stacks core repo: stacks-network/stacks-core#4221

Quote from my reply there

I believe this is currently working as intended atleast from the stacks-core perspective, I think what is not intended is that the wallet shows these "duplicate" transactions when they are not completely replaced on all nodes before one of them gets mined (that is what happens in the ideal situation).

They are unprocessable transactions and should be classified as such by the API, wallets use to display the status of transactions. This could help resolve hirosystems/explorer#1038 (API side), #1867 (wallet side)

And perhaps this discussion could mean other solutions entirely if it can be changed at the core: stacks-network/stacks-core#4129

I think hiding these transactions in the wallet is a good idea, they just confuse users as it is now.

@fyang1024
Copy link
Author

Thank you. I'll close it now since it's been worked on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants