Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recognition of active account during Stacks contract execution #4599

Closed
markmhendrickson opened this issue Nov 29, 2023 · 6 comments · Fixed by #5152
Closed

Fix recognition of active account during Stacks contract execution #4599

markmhendrickson opened this issue Nov 29, 2023 · 6 comments · Fixed by #5152
Assignees
Labels
area:stacks-contract-execution bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds

Comments

@markmhendrickson
Copy link
Collaborator

The first account in the wallet is shown as the active one for signing, both in the modal's header and in the "switch account" drawer when opened, even when a different account has been connected to the site e.g. https://stacks.gamma.io/

Screen.Recording.2023-11-29.at.16.03.59.mov
@markmhendrickson markmhendrickson added bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds area:stacks-contract-execution labels Nov 29, 2023
@markmhendrickson
Copy link
Collaborator Author

Also affects ALEX here so it doesn't seem app-specific

Screen.Recording.2023-11-29.at.16.06.30.mov

@markmhendrickson
Copy link
Collaborator Author

@314159265359879 can you recreate this?

@314159265359879
Copy link
Contributor

@markmhendrickson I have been able to reproduce this with 6.22.0.
This also explains a couple reports by users from the past months.

@314159265359879
Copy link
Contributor

314159265359879 commented Jan 15, 2024

It is the same on Bitcoin apps and Stacks apps.

@314159265359879
Copy link
Contributor

314159265359879 commented Jan 15, 2024

Steps to reproduce (Stacks)

  1. Sign in to stacks.gamma.io on account 4
  2. Then on the Leather extension switch to account 1
  3. Try to buy a random NFT
  4. See the screen pop up with Account 1 top left (expected is account 4).
  5. Upon confirmation the transaction is still signed with account 4.

Or with bitcoin

  1. Sign in to gamma.io on account 4
  2. Then on the leather extension switch to account 1
  3. Try to buy an ordinal or create an inscription
  4. See the screen pop up with Account 1 top left (expected is account 4).
  5. On bitcoin this is a bit different... on unisat the transaction is signed with account 1 when inscribing something!
    on magiceden there is no error and no broadcast... just "loading, please wait..." and no way to resubmit/sign
    on gamma.io (buying a recent print for example) there is no broadcast after confirming. captured in a seperate issue here: Display account in app nav whenever signing via API #4859

@pete-watters
Copy link
Contributor

I added Edgars fix in this PR based on Edgars PR .

However, when this is released, we will no longer see the account at all in the header as when implementing global headers #4655 we changed this header so that it only shows the logo and not the account:
Screenshot 2024-04-03 at 11 09 12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:stacks-contract-execution bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds
Projects
None yet
4 participants