Feature: Settings

[mica000]

This feature uses the dropdown menu from this task #4312

https://www.figma.com/file/2MLHeIeL6XPVi3Tc2DfFCr/%E2%9D%96-Leather-%E2%80%93-Design-System?type=design&node-id=10352-137977&mode=design&t=hjqmbIyJGAvKngKO-4

Screen.Recording.2023-12-06.at.21.43.37.mov

[pete-watters]

@markmhendrickson @mica000 - I'm just going to implement this now in #4370 , I hope thats OK?

It makes sense to do as I need that new menu and it will help to fix #4826 and #4826 anyway.

[mica000]

@pete-watters Sounds great! Let me add the icons to this ticket as I forgot about this.

[markmhendrickson]

Works for me!

[mica000]

@pete-watters Settings icons.zip

Some of them are new, so they will need to be added to the Icons Package

[fbwoolf]

Some of them are new, so they will need to be added to the Icons Package

This process here isn't great bc I'm working on this!

[mica000]

Sorry! My bad! There is indeed an overlap between the tasks. In this case, since you are working on the Icons Package, guess they will be added there and then Pete will pull them to this feature, I assume?

[fbwoolf]

Sorry! My bad! There is indeed an overlap between the tasks. In this case, since you are working on the Icons Package, guess they will be added there and then Pete will pull them to this feature, I assume?

Sounds good, can you add to the Icon Export list? Pete can keep using the PlaceholderIcon until I get mine merged.

[pete-watters]

@fbwoolf don't worry, I will use placeholders then consume the icons when ready 👍

Thanks!

[pete-watters]

I've implemented most of this, without the icons and using the menu items we have already.

I am facing some weird UX issues with the sub-menu dropdown so I am deferring work on that for now and we may consider how we intend to use it. You can see in here:

SettingsDropdown.mp4

• we need the sub menu to open on the opposite side and it's against the natural flow
• to use the keyboard we need to use the right arrow but the menu is shown on the left
• we don't really have space to have a sub-menu in extension mode
• it's quite hard to hover and then click so it's unusable right now

No doubt with some more work we can figure this out but for now I will just implement the basics

[mica000]

Thanks @pete-watters!
Should we provide feedback on it?
If so, could you share the link to the PR?

[pete-watters]

Thanks @pete-watters! Should we provide feedback on it? If so, could you share the link to the PR?

Sure, share feedback if you want. I have more work to do fixing bugs but I will take it into consideration.

It's the same PR as containers - #4655

[fbwoolf]

I changed the milestone for this issue bc I couldn't easily find it. It is being worked on with the container work.

[pete-watters]

Moved this into code review now as I made a final change to settings menu width so it should be complete now

[mica000]

Great work here! 👏👏👏👏👏