Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance displayed as -1 with pending transfer #3716

Closed
whoabuddy opened this issue May 16, 2023 · 7 comments
Closed

Balance displayed as -1 with pending transfer #3716

whoabuddy opened this issue May 16, 2023 · 7 comments
Assignees
Labels
area:balances bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds effort:small Expected to take up to 1 day of integration work

Comments

@whoabuddy
Copy link

Ran into this with a fresh account - after sending some STX to it the main page shows a balance of -1 while the activity tab shows the correct amount.

Screenshot from 2023-05-16 15-33-34

Screenshot from 2023-05-16 15-33-51

@314159265359879 314159265359879 added bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds labels May 17, 2023
@github-project-automation github-project-automation bot moved this to Enhancements backlog in Hiro Wallet (DEPRECATED) May 17, 2023
@314159265359879 314159265359879 moved this from Enhancements backlog to Bugs backlog in Hiro Wallet (DEPRECATED) May 17, 2023
@314159265359879
Copy link
Contributor

Thanks for reporting Jason! Another user reported this too.

@314159265359879
Copy link
Contributor

314159265359879 commented May 19, 2023

I see more examples:
image

On this address I see a pending (yet unprocessable because the nonce is already used) transaction, does that have anything to do with this bug?
image

@314159265359879 314159265359879 moved this from Bugs backlog to Triage in Hiro Wallet (DEPRECATED) May 25, 2023
@markmhendrickson
Copy link
Collaborator

@alter-eggo any idea if your recent work re: available balances could have been related to this at first glance?

@314159265359879
Copy link
Contributor

This looks like two issues

  1. (this?) Don't subtract the balance if the transfer is outgoing but the transaction is unprocessed/unprocessable (we need that state to be added, I think it would resolve this right away because it would not be pending anymore). Not sure what to do meantime, I am hoping @alter-eggo has a creative idea :-)

  2. fees from incoming transactions are subtracting: Don't subtract fee from balance for incoming Stacks transactions #3761

@alter-eggo
Copy link
Contributor

yeah, prob it is affected by work with available balances. I'll take a look

@markmhendrickson markmhendrickson added area:balances effort:small Expected to take up to 1 day of integration work labels Jun 20, 2023
@alter-eggo alter-eggo moved this from Assigned to WIP in Hiro Wallet (DEPRECATED) Jun 27, 2023
@alter-eggo alter-eggo moved this from WIP to Review in Hiro Wallet (DEPRECATED) Jun 27, 2023
@alter-eggo
Copy link
Contributor

fixed in this issue #3761
can we close this one? @markmhx @314159265359879

@314159265359879
Copy link
Contributor

Tested, confirmed fixed, thanks @alter-eggo!

@314159265359879 314159265359879 moved this from Review to Released in Hiro Wallet (DEPRECATED) Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:balances bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds effort:small Expected to take up to 1 day of integration work
Projects
None yet
Development

No branches or pull requests

4 participants