Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review layouts and responsiveness in pages #2314

Closed
1 of 3 tasks
landitus opened this issue Mar 18, 2022 · 3 comments
Closed
1 of 3 tasks

Review layouts and responsiveness in pages #2314

landitus opened this issue Mar 18, 2022 · 3 comments

Comments

@landitus
Copy link

landitus commented Mar 18, 2022

There are inconsistencies in the page layouts, regarding how the content is positioned and scrolled. This is specially noticeable in the large size, and not in the smaller widget. So far, I've noticed that Fund account, Receive and Secret keys pages have vertically centered contents. When the viewport is shorter, the elements collide with the header and get cut off the viewport. Unlike the Send page, which has normal scrolling and positioning and any viewport size.

Scope

Examples

Screenshot 2022-03-18 at 15 47 34

@landitus landitus changed the title Review responsive page layout and scrolling for pages Review responsive behavior for pages Mar 18, 2022
@landitus landitus self-assigned this Mar 18, 2022
@landitus landitus added this to the Design improvements milestone Mar 18, 2022
@landitus landitus changed the title Review responsive behavior for pages Review responsive behavior in pages Mar 18, 2022
@landitus
Copy link
Author

As @fbwoolf has been improving the responsiveness of the app, the first step would be to review this PR #2277 and check if the visual bugs persist.

@landitus
Copy link
Author

#2277 Will fix all centering and scrolling issues and will get us to a better place in terms of layout and responsiveness. Still, I found more inconsistencies in the headings and navigation. The next step is re-define the spec for the layout and navigation.

@landitus landitus changed the title Review responsive behavior in pages Review layouts and responsiveness in pages Mar 21, 2022
@pete-watters
Copy link
Contributor

Closing this off as I believe it to be outdated and we have improved our responsiveness a lot in #5176

@pete-watters pete-watters self-assigned this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants