From a50a55073e29361db2eec822bac7503ff2c25025 Mon Sep 17 00:00:00 2001 From: Pete Watters <2938440+pete-watters@users.noreply.github.com> Date: Tue, 9 Apr 2024 11:06:52 +0100 Subject: [PATCH] fix: don't allow user to close non cancellable ledger actions, closes #5143 --- .../broadcast-error-dialog.tsx | 4 +- src/app/features/container/container.tsx | 2 + .../edit-nonce-dialog/edit-nonce-dialog.tsx | 4 +- .../high-fee-dialog/high-fee-dialog.tsx | 4 +- .../increase-btc-fee-dialog.tsx | 4 +- .../increase-fee-sent-dialog.tsx | 4 +- .../increase-stx-fee-dialog.tsx | 4 +- .../components/account-list-unavailable.tsx | 38 +++++++++--------- .../switch-account-dialog.tsx | 13 ++++-- .../ledger-bitcoin-sign-tx-container.tsx | 2 +- .../jwt-signing/ledger-sign-jwt-container.tsx | 13 +++--- .../ledger-stacks-sign-msg-container.tsx | 16 ++++---- .../request-keys/request-keys-flow.tsx | 23 ++++++----- .../tx-signing/tx-signing-flow.tsx | 20 ++-------- .../connect-ledger-error.layout.tsx | 4 +- .../connect-device/connect-ledger-start.tsx | 4 +- .../unsupported-browser.layout.tsx | 4 +- .../ledger/hooks/use-ledger-navigate.ts | 10 ++--- .../ledger/utils/stacks-ledger-utils.ts | 4 +- ...trieve-taproot-to-native-segwit.layout.tsx | 4 +- src/app/features/settings/network/network.tsx | 4 +- .../features/settings/sign-out/sign-out.tsx | 4 +- .../features/settings/theme/theme-dialog.tsx | 4 +- .../rpc-sign-bip322-message.tsx | 19 ++++++++- .../send-inscription-choose-fee.tsx | 4 +- .../send-inscription-form.tsx | 4 +- .../send-inscription-review.tsx | 4 +- .../sent-inscription-summary.tsx | 4 +- .../recipient-accounts-dialog.tsx | 4 +- src/app/routes/app-routes.tsx | 6 ++- .../components/containers/dialog/dialog.tsx | 6 +-- .../components/header-action-button.tsx | 17 +++----- .../containers/headers/dialog-header.tsx | 40 +++++++++++++++++++ .../components/containers/headers/header.tsx | 6 +-- 34 files changed, 175 insertions(+), 132 deletions(-) create mode 100644 src/app/ui/components/containers/headers/dialog-header.tsx diff --git a/src/app/components/broadcast-error-dialog/broadcast-error-dialog.tsx b/src/app/components/broadcast-error-dialog/broadcast-error-dialog.tsx index 22a026d18b9..574a2a99a5a 100644 --- a/src/app/components/broadcast-error-dialog/broadcast-error-dialog.tsx +++ b/src/app/components/broadcast-error-dialog/broadcast-error-dialog.tsx @@ -7,7 +7,7 @@ import get from 'lodash.get'; import { Button } from '@app/ui/components/button/button'; import { Dialog } from '@app/ui/components/containers/dialog/dialog'; import { Footer } from '@app/ui/components/containers/footers/footer'; -import { Header } from '@app/ui/components/containers/headers/header'; +import { DialogHeader } from '@app/ui/components/containers/headers/dialog-header'; export function BroadcastErrorDialog() { const navigate = useNavigate(); @@ -17,7 +17,7 @@ export function BroadcastErrorDialog() { return ( } + header={} onClose={() => navigate('..')} footer={