Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize KCardGrid's internal usage of watchers #801

Open
MisRob opened this issue Oct 15, 2024 · 0 comments
Open

Optimize KCardGrid's internal usage of watchers #801

MisRob opened this issue Oct 15, 2024 · 0 comments
Assignees

Comments

@MisRob
Copy link
Member

MisRob commented Oct 15, 2024

Summary

In #796, I experienced problems with reactivity when using computed in some places. I was able to track it to useKResponsiveWindow, but am still not clear what exactly was going on. I temporarily resolved it by using watch even in places that would benefit from computed. The goal of this issue is to audit all watchers in lib/cards files and refactor to computed where possible or debug and comment on why watch has to be used exactly.

The Value Add

  • Reduces tech debt
  • computed model is more intuitive in some places
  • computed is generally more performant than watch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant