feat: BitVec analogues of Nat.{mul_two, two_mul, mul_succ, succ_mul} #5410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
hargoniX
reviewed
Sep 20, 2024
| @@ -1664,6 +1664,15 @@ theorem BitVec.mul_add {x y z : BitVec w} : | |||
| rw [Nat.mul_mod, Nat.mod_mod (y.toNat + z.toNat), | |||
| ← Nat.mul_mod, Nat.mul_add] | |||
|
|
|||
| theorem mul_succ {x y : BitVec w} : x * (y + 1#w) = x * y + x := by simp [BitVec.mul_add] | |||
There was a problem hiding this comment.
Can we make these binders explicit for consistency with the respective Nat theorems?
There was a problem hiding this comment.
It's not totally clear to me, because right above, there's theorem BitVec.mul_add {x y z : BitVec w} : .... I made these implicit following the above, because x, y can be determined by the equality.
There was a problem hiding this comment.
This is generally treated inconsistently in the BitVec file and I would really like this to become consistent. @hargoniX, is there official guidance how to choose here -- at best with an explanation why a certain style is preferred?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @hargoniX .