Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying lcmgen doesn't rebuild the tests #490

Closed
judfs opened this issue Feb 16, 2024 · 1 comment
Closed

Modifying lcmgen doesn't rebuild the tests #490

judfs opened this issue Feb 16, 2024 · 1 comment

Comments

@judfs
Copy link
Contributor

judfs commented Feb 16, 2024

Say I checkout master and run make; make test. -> "100% tests passed, 0 tests failed out of 14".

Now I add some garbage to emit_python.c and run make; make test. I still get "100% tests passed, "

But if I run

rm -r test
make -j > /dev/null
make test

Now I get the expected "13/14 Test #13: Python::client_server ...............***Failed 1.69 sec".

This seems super bothersome to fix in the cmake... At least from what I can tell. Might be best to just document this in docs/content/contributing.md?

@nosracd
Copy link
Contributor

nosracd commented Jun 16, 2024

This seems super bothersome to fix in the cmake... At least from what I can tell. Might be best to just document this in docs/content/contributing.md?

I briefly looked into a programmatic solution but nothing jumped out at me, so I'm thinking documenting it is the correct solution. In that case, the issue is resolved by #507.

@nosracd nosracd closed this as completed Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants