Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ESP32 Framework Kills IPAddress Check #21

Closed
lbussy opened this issue Jan 18, 2021 · 2 comments · Fixed by #22 or #23
Closed

New ESP32 Framework Kills IPAddress Check #21

lbussy opened this issue Jan 18, 2021 · 2 comments · Fixed by #22 or #23
Assignees
Labels
bug Something isn't working

Comments

@lbussy
Copy link
Owner

lbussy commented Jan 18, 2021

Using an updated arduino-esp32 build the folowing errors were raised:

.pio\libdeps\tft_espi\LCBUrl\src\LCBUrl.cpp:301:23: error: ambiguous overload for 'operator==' (operand types are 'IPAddress' and 'u32_t {aka unsigned int}')
         if (ipaddress == IPADDR_NONE)

Apparently IPADDR_NONE is now a u32_t.

@lbussy lbussy added the bug Something isn't working label Jan 18, 2021
@lbussy lbussy self-assigned this Jan 18, 2021
@lbussy lbussy linked a pull request Jan 18, 2021 that will close this issue
@magillus
Copy link

magillus commented Mar 3, 2021

@lbussy thank for showing work around, will this be released in new version? (I use PlatformIO)

@lbussy
Copy link
Owner Author

lbussy commented Mar 3, 2021

It is in the devel branch right now, it will be released as soon as I can here. I was hoping to get a few more tests done.

@lbussy lbussy linked a pull request Mar 3, 2021 that will close this issue
@lbussy lbussy closed this as completed in #23 Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants