From aa7a355eae2a618170fbc0488b811f37ff20c4d0 Mon Sep 17 00:00:00 2001
From: lbressler13 <lbressler13@gmail.com>
Date: Tue, 23 Jan 2024 12:43:21 -0500
Subject: [PATCH] fix: use correct var name

---
 .../exactfraction/ExactFractionOverflowException.kt         | 2 +-
 .../exactnumbers/exactfraction/exactFractionHelpers.kt      | 6 +++---
 .../exactnumbers/expressions/term/getComponentsTests.kt     | 1 -
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/exact-numbers/src/main/kotlin/xyz/lbres/exactnumbers/exactfraction/ExactFractionOverflowException.kt b/exact-numbers/src/main/kotlin/xyz/lbres/exactnumbers/exactfraction/ExactFractionOverflowException.kt
index c9db7d2..3f54f5b 100644
--- a/exact-numbers/src/main/kotlin/xyz/lbres/exactnumbers/exactfraction/ExactFractionOverflowException.kt
+++ b/exact-numbers/src/main/kotlin/xyz/lbres/exactnumbers/exactfraction/ExactFractionOverflowException.kt
@@ -2,7 +2,7 @@ package xyz.lbres.exactnumbers.exactfraction
 
 /**
  * [ArithmeticException] for ExactFraction overflow.
- * Has field for string of value that caused overflow.
+ * Has field for string representation of value that caused overflow
  */
 class ExactFractionOverflowException() : ArithmeticException() {
     override var message: String? = null
diff --git a/exact-numbers/src/main/kotlin/xyz/lbres/exactnumbers/exactfraction/exactFractionHelpers.kt b/exact-numbers/src/main/kotlin/xyz/lbres/exactnumbers/exactfraction/exactFractionHelpers.kt
index 39c416e..a3516b4 100644
--- a/exact-numbers/src/main/kotlin/xyz/lbres/exactnumbers/exactfraction/exactFractionHelpers.kt
+++ b/exact-numbers/src/main/kotlin/xyz/lbres/exactnumbers/exactfraction/exactFractionHelpers.kt
@@ -26,13 +26,13 @@ internal fun simplifyFraction(numerator: BigInteger, denominator: BigInteger): T
 
     // move negatives to numerator
     if (newDenominator.isNegative()) {
-        newNumerator = -numerator
-        newDenominator = -denominator
+        newNumerator = -newNumerator
+        newDenominator = -newDenominator
     }
 
     // simplify using greatest common divisor
     if (newNumerator != BigInteger.ZERO) {
-        val gcd = getGCD(numerator, denominator)
+        val gcd = getGCD(newNumerator, newDenominator)
         newNumerator /= gcd
         newDenominator /= gcd
     }
diff --git a/exact-numbers/src/test/kotlin/xyz/lbres/exactnumbers/expressions/term/getComponentsTests.kt b/exact-numbers/src/test/kotlin/xyz/lbres/exactnumbers/expressions/term/getComponentsTests.kt
index 785f293..7a50b3c 100644
--- a/exact-numbers/src/test/kotlin/xyz/lbres/exactnumbers/expressions/term/getComponentsTests.kt
+++ b/exact-numbers/src/test/kotlin/xyz/lbres/exactnumbers/expressions/term/getComponentsTests.kt
@@ -17,7 +17,6 @@ private val testNumber1 = TestNumber(ExactFraction(3, 4))
 private val testNumber2 = TestNumber(ExactFraction.SEVEN)
 private val one = ExactFraction.ONE
 
-@Suppress("Deprecated")
 fun runGetFactorsByTypeTests() {
     val types = listOf(Log.TYPE, Pi.TYPE, Sqrt.TYPE, TestNumber.TYPE)