Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make table member list attribute of CustomerAssignment #1

Open
laurimi opened this issue Oct 20, 2017 · 0 comments
Open

Make table member list attribute of CustomerAssignment #1

laurimi opened this issue Oct 20, 2017 · 0 comments
Labels
enhancement

Comments

@laurimi
Copy link
Owner

laurimi commented Oct 20, 2017 •
edited
Loading

Currently, CustomerAssignment::get_table_members works by generating a new set for the table members every time the function is called. Based on some quick profiling, this seems to be rather time consuming. Efficiency can be improved by returning const references to table member sets stored internally in CustomerAssignment, or other similar ideas.

In the worst case, this might require messing around with the internal implementation of the tables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laurimi