Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Runtime Permissions #313

Closed
2 of 8 tasks
derrafa opened this issue Mar 20, 2018 · 5 comments
Closed
2 of 8 tasks

Feature Request: Runtime Permissions #313

derrafa opened this issue Mar 20, 2018 · 5 comments
Labels
enhancement Feature requests and code enhancements stale An issue that hasn't been active for a while...

Comments

@derrafa
Copy link

derrafa commented Mar 20, 2018

Operating system

  • Windows
  • macOS
  • Linux
  • Android
  • iOS

Application

  • Desktop
  • Mobile
  • Terminal

Hello thanks for the great App. Is there any plan to update the Android mobile app to runtime permissions?

Regards

@derrafa derrafa changed the title Runtime Permissions Feature Request: Runtime Permissions Mar 20, 2018
@laurent22
Copy link
Owner

Sorry what runtime permission do you mean?

@derrafa
Copy link
Author

derrafa commented Mar 20, 2018

When I install Joplin on Android I have to give access to all requested permissions. With Runtime permissions the app just asks for access when it they really needed. As far as I understand it is a newer API level (>=23).

https://developer.android.com/training/permissions/requesting.html
"You declare that your app needs a permission by listing the permission in the app manifest and then requesting that the user approve each permission at runtime (on Android 6.0 and higher). "

@laurent22 laurent22 added the enhancement Feature requests and code enhancements label Mar 26, 2018
@xuhcc
Copy link
Contributor

xuhcc commented Aug 1, 2019

Filesystem permission request added here: #1665
Camera and location permissions are also requested at runtime.

So probably we can remove permission notice from the config screen (https://github.com/laurent22/joplin/blob/v1.0.163/ReactNativeClient/lib/components/screens/config.js#L387) and close this issue.

@stale
Copy link

stale bot commented Oct 30, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Oct 30, 2019
@stale
Copy link

stale bot commented Nov 6, 2019

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Nov 6, 2019
@lock lock bot locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Feature requests and code enhancements stale An issue that hasn't been active for a while...
Projects
None yet
Development

No branches or pull requests

3 participants