Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Resolves: Generate .deb installer for Joplin Desktop #11526

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

pedr
Copy link
Collaborator

@pedr pedr commented Dec 16, 2024

Summary

Creates a .deb installer for Joplin Desktop.

By default, the electron-builder will use the package name as the name of the executable, so I add an executableName so package can be executed in CLI by running joplin instead of @joplinapp-desktop, for similar reason I also added the artifactName, without it the debian file would end-up on app-desktop/dist/@joplin/ instead of app-desktop/dist/.

Information about the package after installation ``` js@mint:~/Desktop/joplin/fork/packages/app-desktop/dist$ sudo apt show joplin Package: joplin Version: 3.2.4 Status: install ok installed Priority: optional Section: default Maintainer: Joplin Team Installed-Size: 867 MB Depends: libgtk-3-0, libnotify4, libnss3, libxss1, libxtst6, xdg-utils, libatspi2.0-0, libuuid1, libsecret-1-0 Recommends: libappindicator3-1 Homepage: https://github.com/laurent22/joplin#readme License: AGPL-3.0-or-later Vendor: Joplin Team Download-Size: unknown APT-Manual-Installed: yes APT-Sources: /var/lib/dpkg/status Description: Joplin for Desktop ```

Testing

  1. On a Linux machine
  2. Run yarn dist on app-desktop project
  3. After the process is finished there should be one .Appimage and one .deb binary inside the app-desktop/dist folder
  4. It should be possible to run sudo dpkg -i Joplin-${version}.deb to install the package on Debian derivated machines

@pedr pedr added enhancement Feature requests and code enhancements desktop All desktop platforms labels Dec 16, 2024
@pedr pedr requested a review from laurent22 December 16, 2024 21:20
@laurent22 laurent22 merged commit b147cc6 into laurent22:dev Dec 17, 2024
7 checks passed
@pedr pedr deleted the generate-deb-installer branch December 18, 2024 18:01
@graphit0
Copy link

Just a heads up that in-app update from .deb version still downloads .AppImage package (not .deb one as expected).

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop All desktop platforms enhancement Feature requests and code enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants