feat: Redact anonymous attributes within feature events #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #228721: Anonymous attribute redaction for feature events. |
keelerm84
force-pushed
the
mk/sc-228721/anonymous-redaction
branch
from
e9b0c8b
to
a3bfde1
Compare
cwaldren-ld
reviewed
Jan 9, 2024
lib/ldclient-rb/events.rb
Outdated
| out[:default] = event.default unless event.default.nil? | ||
| out[:variation] = event.variation unless event.variation.nil? | ||
| out[:version] = event.version unless event.version.nil? | ||
| out[:prereqOf] = event.prereq_of unless event.prereq_of.nil? | ||
| out[:context] = @context_filter.filter(event.context) | ||
| out[:context] = @context_filter.filter(event.context, true) |
There was a problem hiding this comment.
I'm not so sure as with Go so I'll defer to you, but I think it'd be clearer to have another method that takes the boolean param (filter_redact_anonymous) or something? That way most callers don't change.
There was a problem hiding this comment.
I went ahead and introduced it to keep it consistent. I'll do this in the other implementations when possible.
cwaldren-ld
approved these changes
Jan 9, 2024
Base automatically changed from
mk/sc-223829/inline-contexts
to
feat/inline-contexts
January 16, 2024 15:14
keelerm84
force-pushed
the
mk/sc-228721/anonymous-redaction
branch
from
c2eb498
to
77ebb82
Compare
keelerm84
added a commit
that referenced
this pull request
Mar 13, 2024
keelerm84
added a commit
that referenced
this pull request
Mar 14, 2024
keelerm84
pushed a commit
that referenced
this pull request
Mar 14, 2024
🤖 I have created a release *beep* *boop* --- ## [8.3.0](8.2.0...8.3.0) (2024-03-14) ### Features * Inline contexts for all evaluation events ([#245](#245)) ([bd30c3b](bd30c3b)) * Redact anonymous attributes within feature events ([#246](#246)) ([640ac39](640ac39)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.