Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove workarounds for .mts, .cjs, etc. files #636

Closed
Tracked by #673
holic opened this issue Apr 17, 2023 · 1 comment
Closed
Tracked by #673

remove workarounds for .mts, .cjs, etc. files #636

holic opened this issue Apr 17, 2023 · 1 comment

Comments

@holic
Copy link
Member

holic commented Apr 17, 2023 •
edited
Loading

Just noticed some files were not captured by prettier, etc. because of the .mts. I believe we've since changed some things where these file types are no longer necessary and we can revert back to .ts everywhere? Is that true?

Also in noise package, we swap to .cjs export as part of the build pipeline, can we get back to .js for this?
@holic holic changed the title move off of .mts files remove workarounds for .mts, .cjs, etc. files Apr 17, 2023
@holic holic mentioned this issue Apr 24, 2023
Open
18 tasks
@holic
Copy link
Member Author

holic commented Sep 7, 2023

I think we've squashed all the places we had diff usages of cjs/mjs

@holic holic closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@holic