From 7a84044b6f234659617f2ad238c2912c3fe6e0af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E0=A4=AA=E0=A5=8D=E0=A4=B0=E0=A4=A5=E0=A4=AE=E0=A5=87?= =?UTF-8?q?=E0=A4=B6=20Sonpatki?= Date: Mon, 20 May 2024 15:15:42 +0530 Subject: [PATCH] Don't track `ip` label (#54) - Historically, this label has been source of the high cardinality data. - This is generally handled at the scraper level where instance or pod labels are automatically added. - With support for adding custom labels to every request, users can add `ip` whenever appropriate, it doesn't need to be done by default. --- src/OpenAPM.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/OpenAPM.ts b/src/OpenAPM.ts index 82d93fd..0f9acda 100644 --- a/src/OpenAPM.ts +++ b/src/OpenAPM.ts @@ -35,7 +35,6 @@ export type ExtractFromParams = { export type DefaultLabels = | 'environment' | 'program' - | 'ip' | 'version' | 'host'; @@ -187,8 +186,7 @@ export class OpenAPM extends LevitateEvents { environment: this.environment, program: packageJson?.name ?? '', version: packageJson?.version ?? '', - host: os.hostname(), - ip: getHostIpAddress(), + host: os.hostname(), ...this.defaultLabels };