Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field never used in core #420

Closed
gurghet opened this issue Jul 6, 2021 · 1 comment
Closed

Field never used in core #420

gurghet opened this issue Jul 6, 2021 · 1 comment

Comments

@gurghet
Copy link
Contributor

gurghet commented Jul 6, 2021

The field below, while logically belongs to core, it's never used by it and only used by the modules. This is just code smell and not a real problem but might indicate there is a better way to structure the code.

val recordKey: (S, V) => K

It means it's possible to do things like override Setup and

override val recordKey: (State, LastAlertTime) => LastAlertTimeKey = ???

and make the code still work because you are using a different way to create your record key.

@sirocchj
Copy link
Member

This is now addressed in #1391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants