Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question about threshold of f-measure #2

Closed
Z1Wu opened this issue Mar 12, 2021 · 2 comments
Closed

question about threshold of f-measure #2

Z1Wu opened this issue Mar 12, 2021 · 2 comments

Comments

@Z1Wu
Copy link

Z1Wu commented Mar 12, 2021 •
edited
Loading

Thank you for sharing this cool toolkit.
I have a question about threshold of the f-measure plotting code.

After the np.flip operatoin, the fg_w_thrs becomes [ >= 255, >= 254, ..... ,>=0].
https://github.com/lartpang/Py-SOD-VOS-EvalToolkit/blob/f9c1fd5ffeef1a58067e31b9e6d28e9eb0754c46/metrics/sod/metrics.py#L66

When saving the curve data into np file for ploting , thess lines flip the fm data again.( so now fm should be [0, 1, ...., 255])
https://github.com/lartpang/Py-SOD-VOS-EvalToolkit/blob/f9c1fd5ffeef1a58067e31b9e6d28e9eb0754c46/eval_sod_all_methods.py#L132-L136

But when plotting image, the x axis(threshold) here starts from 1 to 0. I guess this should be from 0 to 1.
https://github.com/lartpang/Py-SOD-VOS-EvalToolkit/blob/f9c1fd5ffeef1a58067e31b9e6d28e9eb0754c46/eval_sod_all_methods.py#L198
@lartpang
Copy link
Owner

Yes, you are right.
Thanks!
I will fix it.

lartpang referenced this issue Mar 12, 2021
@lartpang
- 这一版本正式将sod的评估、绘图代码与配置分离，主要考虑如下
d7bcc1d 
    - 用户的配置是需要调整的，这部分不适宜被git严格的监视，也便于提交后续更新的时候，直接忽略关于配置的更改，即后续更新时，
      用户配置部分会不再更新，若是添加新功能，直接调整原始的函数，其参数默认关闭新功能，保证用户不会受到影响。
    - sod和cosod评估方式有差异，但是绘图方式一致，所以现将评估绘图拆分成独立部分，置于metrics/sod文件夹下，之后或许或调整位置，
      但这种拆分策略不变。
  - 优化了cosod的评估代码，对sod和cosod的指标recorder部分进行了简化。
  - 不再使用独立的sod_metrics代码，由于我已经将PySODMetrics发布到了PyPI上，所以可以直接通过pip安装。
  - 使用添加了对于print的一个彩色增强的封装，可见`./utils/misc.py`中的`colored_print`。
  - git不再跟踪方法配置文件和数据集配置文件，这部分现有的作为示例，仅供使用者独立补充和参考。
  - 修复了之前绘制Fm曲线时x的问题，之前取反了。详见<https://github.com/lartpang/Py-SOD-VOS-EvalToolkit/issues/2>。
@lartpang
Copy link
Owner

It has been fixed. Thank you again!

https://github.com/lartpang/Py-SOD-VOS-EvalToolkit/blob/d7bcc1d74065844fe0483dc3ce3fda7d06d07bc0/metrics/sod/draw_curves.py#L49-L51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Z1Wu @lartpang