Skip to content
This repository has been archived by the owner on Jan 21, 2023. It is now read-only.

module sub-generator inconsistent file name and test import #201

Closed
saun4app opened this issue Feb 21, 2017 · 3 comments
Closed

module sub-generator inconsistent file name and test import #201

saun4app opened this issue Feb 21, 2017 · 3 comments
Assignees

Comments

@saun4app
Copy link
Contributor

saun4app commented Feb 21, 2017

@larsonjj,

Thank you very much for creating generator-yeogurt. Looks like the generator is very well designed. I ran into a small issue. The file name in module/index.js is crated without out _.slugify (line 62):

this.name = this.name.split('/').slice(-1)[0]; 

However, the import statement in module/templtes/module.test.js uses _.slugify and toLowerCase (line 4)

var <%= _.classify(name) %> = require('../<%= _.slugify(name.toLowerCase()) %>');

resulting in failing unit test.

Would you please look into the issue. Thank you very much.

@larsonjj
Copy link
Owner

Hey @saun4app,

v2.0.0 was just released. Could you check and see if fixes your issue?

@saun4app
Copy link
Contributor Author

saun4app commented Feb 27, 2017 via email

@larsonjj
Copy link
Owner

Closing due to inactivity. @saun4app, feel free to reopen if something is unresolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants