Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

[Proposal] Add first and last pagination links #998

Closed
sean-ww opened this issue Feb 13, 2018 · 6 comments
Closed

[Proposal] Add first and last pagination links #998

sean-ww opened this issue Feb 13, 2018 · 6 comments

Comments

@sean-ww
Copy link

sean-ww commented Feb 13, 2018

The pagination would benefit from a first and last button:
screen shot 2018-02-13 at 09 35 46

See PR

Currently in 5.6.3 it has just previous and next with the wrong symbols (fixed here).

@handsomematt
Copy link

please.

@sisve
Copy link

sisve commented Feb 21, 2018

Have you tried sending a PR to the correct repo with a fix?

@sean-ww
Copy link
Author

sean-ww commented Feb 22, 2018

Yes, you can see in the PR links. The fix was merged (fixing the wrong symbols). The subsequent pull request to add first and last was closed due to the belief that it was already first and last. I'll try again perhaps...

@drbyte
Copy link

drbyte commented Feb 22, 2018

@sean-ww note: taylor has said that he has github notifications turned off. So the only way he sees anything about a PR that he's closed is if someone in his inner circle notifies him, or if you open a new PR. So, once he's closed something, you've gotta do a new PR or find someone who can get his attention back to it.

@sean-ww
Copy link
Author

sean-ww commented Feb 22, 2018

Resubmitted the pull request: laravel/framework#23263

@sean-ww
Copy link
Author

sean-ww commented Feb 23, 2018

Closed again: laravel/framework#23263

The reason being that first and last 'numbers' always display. Which to me, isn't intuitive. Let alone to real clients, but I do appreciate now that the functionality is there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants