Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

[proposal] Expected data type should be in accept headers #933

Closed
pavinthan opened this issue Dec 20, 2017 · 2 comments
Closed

[proposal] Expected data type should be in accept headers #933

pavinthan opened this issue Dec 20, 2017 · 2 comments

Comments

@pavinthan
Copy link

pavinthan commented Dec 20, 2017

if someones need the JSON response, they should have Accept header, so you don't need to use ($this->ajax() && ! $this->pjax()) || $this->wantsJson(); checks because some ajax requests may request HTML or XML responses
https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.1

@taylorotwell please review this issue

@pavinthan pavinthan changed the title Regarding response handle changes [proposal] Regarding response handle changes Dec 20, 2017
@sisve
Copy link

sisve commented Dec 20, 2017

The naming of this issue is really vague. "Regarding response handle changes". What response handle? You want to change a response handle?

Why is this even an issue in this repository? There is already an open PR for it since three days back, and we're now discussing details about the fix.

@pavinthan pavinthan changed the title [proposal] Regarding response handle changes [proposal] Expected data type should be in accept headers Dec 20, 2017
@pavinthan
Copy link
Author

@sisve it's not related to adding another check for response the expect type, need to remove other checks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants