Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

[Proposal] Add SFTP filesystem driver out of the box #1002

Closed
jacobmllr95 opened this issue Feb 14, 2018 · 4 comments
Closed

[Proposal] Add SFTP filesystem driver out of the box #1002

jacobmllr95 opened this issue Feb 14, 2018 · 4 comments

Comments

@jacobmllr95
Copy link

In a current project we need to connect to a SFTP server on the fly (with dynamic username/password).
Laravel currently only has a FTP driver out of the box.

I know thats its quit easy to add a new storage driver as described in the docs but the FilesystemManager is then still missing the method to create the driver on the fly.

I do also know that its possible to solve that by extending the FilesystemManager and FilesystemServiceProvider but IMHO Laravel should ship with SFTP support out of the box.

@tomschlick
Copy link

https://flysystem.thephpleague.com/adapter/sftp/ this adds the adapter to flysystem.

I disagree it should be in core. 99% of apps don't interact with SFTP in any way.

@jacobmllr95
Copy link
Author

The question is how many do with FTP.
I just expected that when FTP is supported, SFTP is too. Because they are kinda similar.

@mfn
Copy link

mfn commented Feb 14, 2018

Because they are kinda similar

Only by their name. Technically they're two different worlds.

I'm with @tomschlick on this matter.

@jacobmllr95
Copy link
Author

Closed by laravel/framework#23308.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants