MigrationCreator::firePostCreateHooks not backwards compatible with current version.

[chrishalbert]

• Laravel Version: 5.6.28
• PHP Version: 7.1
• Database Driver & Version: N/A

Description:

The recent change to MigrationCreator::firePostCreateHooks() adds an additional parameter to the method signature. This method is protected, however, subclasses can still call/rely on this in earlier versions. For prior versions of 5.6, we'll see breaking changes.

Steps To Reproduce:

When I run my build on travis-ci for https://github.com/chrishalbert/laravel-nomadic project on 7.1, I see this output: https://travis-ci.org/chrishalbert/laravel-nomadic/jobs/406202387.

PR coming your way.

[Miguel-Serejo]

Laravel doesn't follow semver. https://laravel.com/docs/5.6/releases#versioning-scheme

[chrishalbert]

True, however, according to: Minor features that are fully backwards compatible with the current Laravel release may be sent to the latest stable branch. ref: https://laravel.com/docs/5.6/contributions#which-branch, this should still be fully compatible with the rest of 5.6, which it is not.

[chrishalbert]

Editing ticket description per your notes @36864

[chrishalbert]

#24916

[chrishalbert]

Closing this as no plans are to fix this

If anyone comes by this in their code, you can just add a default unused param as a work around:

    protected function firePostCreateHooks($table = null)
    {
        $this->fireHook($this->postCreate);
    }