Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support custom URLs for S3 storage #24591

Closed
finagin opened this issue Jun 14, 2018 · 2 comments
Closed

Fix support custom URLs for S3 storage #24591

finagin opened this issue Jun 14, 2018 · 2 comments

Comments

@finagin
Copy link
Contributor

finagin commented Jun 14, 2018

  • Laravel Version: ≥5.5.21
  • PHP Version: not relevant
  • Database Driver & Version: not relevant

Description:

AWS-SDK-S3 don't support url. Needs endpoint configuration variable.

This way works only for FilesystemAdapter::url, but not for other methods like exists, put, temporaryUrl etc. with S3 adapter.

Steps To Reproduce:

  1. In config/filesystems.php set s3.url not AWS S3 like https://hb.bizmrg.com
  2. Call Storage::cloud()->put('test/test.txt', 'cloud');

Steps To Solution:

  1. Revert [5.5] Support custom URLs for AWS storage #22037
  2. Fix Support custom URLs for AWS storage laravel#4483 change url to endpoint
@finagin
Copy link
Contributor Author

finagin commented Jun 14, 2018

laravel/laravel#4686 and #24593 must be merged together

@driesvints
Copy link
Member

Going to close this as the PRs were closed as well. I think it's best if you lay down your use case at https://github.com/laravel/ideas first to gather support and try again with the info Taylor has requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants