Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tightenco/collect version constraints #23366

Closed
brendt opened this issue Mar 2, 2018 · 4 comments
Closed

tightenco/collect version constraints #23366

brendt opened this issue Mar 2, 2018 · 4 comments

Comments

@brendt
Copy link
Contributor

brendt commented Mar 2, 2018

  • Laravel Version: 5.6.4 or higher
  • PHP Version: 7.2

Description:

This commit sets the replacement version of tightenco/collect to <5.5.33: 5caa88a

This means that packages depending on tightenco/collect:^5.6 aren't able to install with the latest laravel version. An example is our crawler package: https://github.com/spatie/crawler

Is this intentional?

@sisve
Copy link
Contributor

sisve commented Mar 2, 2018

Yes, because tightenco/collect changed the namespace of their Collection class from Illuminate\Support to Tightenco\Collect\Support in 5.5.33. We cannot claim that we replace another package if we do not have classes in the same namespaces.

If I understand the entries correctly, this means that we can replace releases before tightenco/collect 5.5.33, but that releases including and after tightenco/collect 5.5.33 should still be installed.

A fresh new Laravel 5.6.7 project can install the spatie/crawler package (I got 4.0.3) without any issues, and it installs tightenco/collect 5.6.7 for me.

@it-can
Copy link
Contributor

it-can commented Mar 2, 2018

@sisve and if you try to install composer require spatie/laravel-sitemap ?

I am getting a error on a new install...

@mathieutu
Copy link
Contributor

Duplicate : #23272

@themsaid themsaid closed this as completed Mar 2, 2018
@sisve
Copy link
Contributor

sisve commented Mar 3, 2018

I was wrong in my initial test, I messed up my folders.

I cannot install spatie/crawler into a new laravel/laravel project. I'll update #23272 with details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants