LogManager returns new instance of Logger at each call instead of returning the same instance

[CyrilMazur]

• Laravel Version: 5.6.3
• PHP Version: 7.1.13
• Database Driver & Version: n/a

Description:

Illuminate\Log\LogManager returns a new Logger instance every time instead of making one instance and returning the same instance in subsequent calls.

According to the source (see

framework/src/Illuminate/Log/LogManager.php

Lines 106 to 125 in 38284c8

	/**
	* Attempt to get the log from the local cache.
	*
	* @param string $name
	* @return \Psr\Log\LoggerInterface
	*/
	protected function get($name)
	{
	try {
	return $this->channels[$name] ?? with($this->resolve($name), function ($logger) use ($name) {
	return $this->tap($name, new Logger($logger, $this->app['events']));
	});
	} catch (Throwable $e) {
	return tap($this->createEmergencyLogger(), function ($logger) use ($e) {
	$logger->emergency('Unable to create configured logger. Using emergency logger.', [
	'exception' => $e,
	]);
	});
	}
	}

), it is not intended to return a new instance every time, but instead get an existing instance from the "local cache", which is the $channels property. From my tests, the $channels property remains always empty, no matter how many times I request the same log channel.

Steps To Reproduce:

dd(
    app('log')->channel('stack')->getLogger(),
    app('log')->channel('stack')->getLogger(), // different instance from above
    app('log')->channel('stack')->getLogger() // yet another instance
);

[CyrilMazur]

I submitted a PR to show how I'd fix this: #23118