Deleting models while joined with another table with a where clause messes up the bindings.

[mihkelallorg]

• Laravel Version: 5.1.46
• PHP Version: 7.0.17
• Database Driver & Version: MySQL 5.7.17 (Although I tackled the issue in SQLite also)

Description:

When trying to softdelete a model while joining with another table and using a where clause in the join function messes up the bindings.

Steps To Reproduce:

Model is using softdeletes, while the joined one is not.

Model::join('table', function($join) {
    $join->on('key', '=', 'otherKey')
         ->where('field', '=', 'foobar')
    })->delete();
}

Now the query, which is correct, is:

UPDATE model INNER JOIN table ON key = otherKey AND table.field = ? SET deleted_at = ?, updated_at = ? WHERE model.deleted_at IS NULL

But the bindings are messed up as the last one should be the first one actually:

"bindings" = [
    [0] => "2017-04-26 11:26:50",
    [1] => "2017-04-26 11:26:50",
    [2] => "foobar",
]

[Dylan-DPC-zz]

5.1 is no longer supported. Can you check if issue persists on 5.5?

[abdumu]

The mentioned problem is no longer valid - in my tests.
but there is a new problem - using same code above, this appear:

Integrity constraint violation: 1052 Column 'updated_at' in field list is ambiguous

MySQL : 5.7.19

[mfn]

@abdumu I believe what you're mentioning is #13909

However:

The mentioned problem is no longer valid - in my tests.
but there is a new problem - using same code above, this appear:

These two sentences contradict itself, don't they? How can we know the binding problem is really gone when the whole thing doesn't yet work? 😄

[abdumu]

@mfn
The mentioned problem: the order of the bindings is not correct, but when I tested the order was correct. So, 'ambiguous' error has nothing to do with bindings problem.

How can we know the binding problem is really gone when the whole thing doesn't yet work?
You can debug and print the prepared Query. you know that right?

Shukran 🙂

[mfn]

Well, then this issue can be closed 😄 👍