Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lumen support #31

Open
welsipieters opened this issue Feb 22, 2021 · 3 comments
Open

Lumen support #31

welsipieters opened this issue Feb 22, 2021 · 3 comments

Comments

@welsipieters
Copy link

Hi!

First of all, great package. It does everything I need it to do and more. At my work we have a bunch of microservices written in Lumen, and we'e looking for a good solution to implement the json:api schema in these services. I read the doc, but couldn't find a mention of the Lumen framework anywhere. Is support for Lumen on the roadmap? And is it something that you might be accepting PR's for?

Thanks.

@lindyhopchris
Copy link
Contributor

Hi, glad you like the package!

So the intention is to have a laravel-json-api/lumen package. You'll notice that this Laravel package doesn't have too much code in it - the majority of code is in separate packages that are required via Composer. The code has been written in this way specifically so that there could be a Lumen package too.

The main limitation on doing a Lumen package is I have no projects that use Lumen. That combined with it being a full time job keeping on top of issues in the Laravel repo means I don't really have the time to do a Lumen package. So if you're interested in collaborating on doing a Lumen package, then we could get one started as laravel-json-api/lumen.

My Lumen knowledge isn't anywhere near as good as my Laravel knowledge. The main thing I think needs sorting out is that this Laravel package uses Form Requests to tie things together - but Form Requests don't exist in Lumen. So the place we'd need to start with is working out what the equivalent design for the form requests in Lumen.

If you take a look at the Form Requests here:
https://github.com/laravel-json-api/laravel/tree/develop/src/Http/Requests

And the controller actions here:
https://github.com/laravel-json-api/laravel/tree/develop/src/Http/Controllers/Actions

Do you have an idea what the equivalent for these would be in Lumen? Or what a general design approach would be?

@welsipieters
Copy link
Author

Hi,

I'll look in to it. I recently started working on a TCP-router ish thing for Lumen so I have some experience with the underlying fast-route implementation. When time permits I'll see if I can figure out a decent way to hook in to all of this and update here.

Cheers!

@lindyhopchris
Copy link
Contributor

Great! Definitely up for working collaboratively on sorting out a Lumen version, as I've always wanted to add Lumen support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants