Simplify level fixing scheme #15936
Simplify level fixing scheme #15936
Conversation
Don't instantiate co- and contravariant inner type variables eagerly. Lift them instead to the reference level, same as for invariant type variables. Fixes scala#15934
|
This makes a different tradeoff to what we had before. It fixes the akka issue. Let's see whether it's uniformly better for the other tests as well. |
|
@WojciechMazur should we run the big CB on this branch or merge and test later? |
|
@odersky We can run it with the Open CB, however, it's currently busy with checking the latest nightly to validate the recent CC merge into the main branch. It's also checking all projects. This means we should be able to get results on a Thursday evening, as the full run takes ~20h. |
|
OK, I merge it now, and then we can see whether the other regression was fixed as well or whether there are new ones. |
|
does this fix need to wait until 3.2.1 @Kordyjan ? - It looks like the regression it fixes was post 3.2.0 so I guess not |
|
The regression found in |
I'm not sure if I understand the question. If regression it fixes was introduced after 3.2.0 then it is ok that the fix will be published in 3.2.1 |
|
And I remember we agreed that considering the potential impact of #15746 we want it merged at the beginning of the 3.2.1 cycle and not rush it into 3.2.0 |
|
I agree this is for 3.2.1 |
Don't instantiate co- and contravariant inner type variables eagerly.
Lift them instead to the reference level, same as for invariant type variables.
Fixes #15934