Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix constructors Java generic signatures #13047

Merged
merged 1 commit into from
Jul 12, 2021
Merged

fix constructors Java generic signatures #13047

merged 1 commit into from
Jul 12, 2021

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Jul 11, 2021

fix #10834

@xuwei-k xuwei-k mentioned this pull request Jul 11, 2021
Closed
dwijnand
dwijnand approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks reasonable and I take the rest of CI passing as a good sign - so LGTM

@bishabosha bishabosha merged commit f581090 into scala:master Jul 12, 2021
@xuwei-k xuwei-k deleted the fix-10834 branch July 12, 2021 10:07
@dwijnand dwijnand added this to the 3.0.2-RC1 milestone Jul 12, 2021
@Kordyjan Kordyjan modified the milestones: 3.0.2-RC1, 3.0.2 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.

Constructors are unnecessarily given Java generic signatures
4 participants
@xuwei-k @dwijnand @bishabosha @Kordyjan