Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain transparent flag on exports #12978

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Retain transparent flag on exports #12978

merged 1 commit into from
Jul 5, 2021

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jun 29, 2021

Fixes #12958

@odersky odersky requested a review from bishabosha June 29, 2021 11:27
bishabosha
bishabosha approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bishabosha
Copy link
Member

bishabosha commented Jul 1, 2021 •
edited
Loading

this will change public API compiled by Scala, so should this be next minor release?

@odersky
Copy link
Contributor Author

odersky commented Jul 5, 2021

this will change public API compiled by Scala, so should this be next minor release?

No, since it works exactly the same if the two files are compiled together or separately.

@odersky odersky merged commit e7eb856 into scala:master Jul 5, 2021
@odersky odersky deleted the fix-12958 branch July 5, 2021 16:26
@Kordyjan Kordyjan added this to the 3.0.2 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

Assignees

@bishabosha bishabosha

Labels
None yet
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.

exported transparent inline methods loose transparency
3 participants
@odersky @bishabosha @Kordyjan