Widen unions before finding members #12925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a prefix in a findMember is an OrType, widen it to its join before computing the selection denotation. This mimics what is done if the prefix is pulled out into a temporary variable. Fixes scala#12909
|
test performance please |
|
performance test scheduled: 2 job(s) in queue, 1 running. |
|
test performance please |
|
performance test scheduled: 3 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/12925/ to see the changes. Benchmarks is based on merging with master (ecbe3d2) |
smarter
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a prefix in a findMember is an OrType, widen it to its join before
computing the selection denotation. This mimics what is done if the
prefix is pulled out into a temporary variable.
Fixes #12909