Hide problematic static forwarders #12860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static forwarders for bridges lead to ambiguous errors in some Java compilers, and the trait setters aren't meant to be called by users. Since we can't remove them without breaking binary-compatibility, we mark them ACC_SYNTHETIC so that Java compilers will ignore them. See also the discussion in scala#12767 which implements an alternate fix. Fixes scala#12753. Co-Authored-By: Lukas Rytz <lukas.rytz@gmail.com>
|
@smarter Judging from 3.0.1-RC2, this will not be in 3.0.1, correct? If you could point me to the nightly releases, I would check if the issue I encountered in the |
|
you can find them in https://repo1.maven.org/maven2/org/scala-lang/scala3-compiler_3/, for example set |
|
Thank you 👍 |
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static forwarders for bridges lead to ambiguous errors in some Java
compilers, and the trait setters aren't meant to be called by users.
Since we can't remove them without breaking binary-compatibility, we
mark them ACC_SYNTHETIC so that Java compilers will ignore them. See
also the discussion in #12767 which implements an alternate fix.
Fixes #12753.
Co-Authored-By: Lukas Rytz