Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Evented implementation for Zend Auth #7

Open
weierophinney opened this issue Dec 31, 2019 · 4 comments
Open

[WIP] Evented implementation for Zend Auth #7

weierophinney opened this issue Dec 31, 2019 · 4 comments

Comments

@weierophinney
Copy link
Member

I've been playing around with making the core of Zend Auth event based, this is very much a WIP but the idea is to support the use cases in the cookbook directory.

Feedback would be appreciated; if it is agreed that this is the right direction to go, I can finish off the code: add tests, docs and migrate the existing adapters to listeners.


Originally posted by @carnage at zendframework/zend-authentication#7

@weierophinney
Copy link
Member Author

After talking with @akrabat at PHPUK I've updated this adding back in some backward compatibility.

The remaining BC breaks are:

authenticate method used to take an adapter; this doesn't quite make sense via the new event based internals and instead needs to take parameters to authenticate against.

I've removed the get/set adapter methods and replaced with an addAdapter method (get/set makes no sense with multiple adapter setup)

It should be noted however that the service still complies with it's interface.


Originally posted by @carnage at zendframework/zend-authentication#7 (comment)

@weierophinney
Copy link
Member Author

@carnage If you're still interested in this approach (and it does look interesting!), please rebase against current develop and re-target the PR against that branch so we can review.

Thanks!


Originally posted by @weierophinney at zendframework/zend-authentication#7 (comment)

@weierophinney
Copy link
Member Author

I'd totally forgotten about this PR

Will try and get some time to bring it up to spec in the next few weeks


Originally posted by @carnage at zendframework/zend-authentication#7 (comment)

@weierophinney
Copy link
Member Author

@weierophinney how keen are you to preserve BC here? Zend auth has basically remained the same since ZF1 and could really use a bit of refactoring (eg adaptors which require you to set them up in advance as opposed to authenticating against given paramters)


Originally posted by @carnage at zendframework/zend-authentication#7 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant