Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable_trace_padding to CairoRunConfig #1233

Merged
merged 12 commits into from
Aug 24, 2023
Merged

Add disable_trace_padding to CairoRunConfig #1233

merged 12 commits into from
Aug 24, 2023

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Jun 14, 2023

This option will allow the user to disable the trace padding added by default when running in proof-mode

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@github-actions
Copy link

github-actions bot commented Jun 14, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 4.401 ± 0.032 4.340 4.461 1.00
head big_factorial 4.474 ± 0.049 4.405 4.561 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 3.827 ± 0.047 3.772 3.931 1.00
head big_fibonacci 3.867 ± 0.042 3.796 3.934 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 10.719 ± 0.053 10.660 10.823 1.00
head blake2s_integration_benchmark 10.840 ± 0.251 10.609 11.493 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.842 ± 0.051 3.796 3.951 1.00
head compare_arrays_200000 3.898 ± 0.031 3.856 3.945 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.561 ± 0.041 2.512 2.657 1.01 ± 0.02
head dict_integration_benchmark 2.547 ± 0.035 2.507 2.613 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.844 ± 0.046 1.802 1.947 1.00
head field_arithmetic_get_square_benchmark 1.869 ± 0.032 1.824 1.930 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 10.881 ± 0.257 10.565 11.379 1.01 ± 0.04
head integration_builtins 10.776 ± 0.292 10.601 11.582 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 11.048 ± 0.170 10.828 11.413 1.01 ± 0.02
head keccak_integration_benchmark 10.963 ± 0.110 10.848 11.231 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.871 ± 0.056 3.795 3.965 1.00
head linear_search 3.892 ± 0.046 3.798 3.950 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.773 ± 0.032 2.720 2.823 1.00
head math_cmp_and_pow_integration_benchmark 2.819 ± 0.031 2.790 2.894 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.508 ± 0.022 2.487 2.552 1.01 ± 0.01
head math_integration_benchmark 2.484 ± 0.015 2.464 2.509 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.208 ± 0.068 2.157 2.381 1.00
head memory_integration_benchmark 2.263 ± 0.042 2.196 2.349 1.02 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.481 ± 0.033 2.435 2.537 1.02 ± 0.02
head operations_with_data_structures_benchmarks 2.444 ± 0.024 2.405 2.485 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 882.2 ± 29.9 856.7 960.0 1.00
head pedersen 954.5 ± 8.2 943.9 971.4 1.08 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.544 ± 0.059 1.491 1.650 1.01 ± 0.04
head poseidon_integration_benchmark 1.533 ± 0.027 1.491 1.586 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.043 ± 0.049 2.978 3.165 1.01 ± 0.02
head secp_integration_benchmark 3.023 ± 0.037 2.986 3.087 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.532 ± 0.032 1.490 1.599 1.00
head set_integration_benchmark 1.593 ± 0.028 1.555 1.638 1.04 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 6.875 ± 0.072 6.769 7.019 1.00
head uint256_integration_benchmark 7.026 ± 0.123 6.871 7.200 1.02 ± 0.02

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #1233 (03abbc6) into main (2d214f7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1233   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files          94       94           
  Lines       38485    38494    +9     
=======================================
+ Hits        37528    37537    +9     
  Misses        957      957           
Files Changed Coverage Δ
cairo-vm-cli/src/main.rs 93.61% <100.00%> (+0.04%) ⬆️
vm/src/cairo_run.rs 99.52% <100.00%> (+0.01%) ⬆️
vm/src/vm/runners/cairo_runner.rs 98.06% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fmoletta fmoletta marked this pull request as ready for review June 14, 2023 15:12
@fmoletta fmoletta marked this pull request as draft June 15, 2023 14:32
@fmoletta fmoletta marked this pull request as ready for review August 23, 2023 14:25
@Oppen Oppen enabled auto-merge August 23, 2023 14:43
@Oppen Oppen added this pull request to the merge queue Aug 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 23, 2023
@fmoletta fmoletta added this pull request to the merge queue Aug 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 23, 2023
@fmoletta fmoletta added this pull request to the merge queue Aug 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 23, 2023
@fmoletta fmoletta added this pull request to the merge queue Aug 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 23, 2023
@fmoletta fmoletta added this pull request to the merge queue Aug 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 23, 2023
@fmoletta fmoletta added this pull request to the merge queue Aug 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 23, 2023
@Oppen Oppen added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit 892afd2 Aug 24, 2023
@Oppen Oppen deleted the disable-trace-padding branch August 24, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants